Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: add proj name to env for fuzz introspector #7856

Merged

Conversation

DavidKorczynski
Copy link
Collaborator

@DavidKorczynski DavidKorczynski marked this pull request as draft June 13, 2022 10:02
@DavidKorczynski
Copy link
Collaborator Author

need to bump too when the fuzz-introspector PR is merged

@Navidem
Copy link
Contributor

Navidem commented Jun 13, 2022

/gcbrun trial_build.py skcms --sanitizer address --fuzzing-engine libfuzzer

@DavidKorczynski
Copy link
Collaborator Author

/gcbrun trial_build.py skcms --sanitizer address --fuzzing-engine libfuzzer

Quick heads up -- the testing should fail as this line https://github.com/google/oss-fuzz/pull/7856/files#diff-43e6fb06733014791deb946732e00f7aa84e62bd1d856b363e5be922573a0e0dR243 depends on merging ossf/fuzz-introspector#327 -- i.e. the main.py does not accept --name before merge and should fail because of this

@DavidKorczynski
Copy link
Collaborator Author

@Navidem updated now

@Navidem
Copy link
Contributor

Navidem commented Jun 13, 2022

/gcbrun trial_build.py skcms --sanitizer address --fuzzing-engine libfuzzer

Quick heads up -- the testing should fail as this line https://github.com/google/oss-fuzz/pull/7856/files#diff-43e6fb06733014791deb946732e00f7aa84e62bd1d856b363e5be922573a0e0dR243 depends on merging ossf/fuzz-introspector#327 -- i.e. the main.py does not accept --name before merge and should fail because of this

This is more to test regression on other builds. I expect this trial_build to succeed, as it is not an introspector build.

@DavidKorczynski
Copy link
Collaborator Author

/gcbrun trial_build.py skcms --sanitizer address --fuzzing-engine libfuzzer

Quick heads up -- the testing should fail as this line https://github.com/google/oss-fuzz/pull/7856/files#diff-43e6fb06733014791deb946732e00f7aa84e62bd1d856b363e5be922573a0e0dR243 depends on merging ossf/fuzz-introspector#327 -- i.e. the main.py does not accept --name before merge and should fail because of this

This is more to test regression on other builds. I expect this trial_build to succeed, as it is not an introspector build.

Ah, sounds good

@DavidKorczynski DavidKorczynski marked this pull request as ready for review June 13, 2022 16:20
@Navidem
Copy link
Contributor

Navidem commented Jun 14, 2022

Is it normal test_projects.py take over 1 hour? I am not seeing any progress when running locally.
Will check it again in the morning.

@DavidKorczynski
Copy link
Collaborator Author

DavidKorczynski commented Jun 14, 2022

Yeah it should take more than 1 hour, but less than 2. You see no progress? what's the log/output and what about the processes running? Also make sure to have this update ossf/fuzz-introspector#328 -- am not 100% sure if it's needed but it could be.

@Navidem
Copy link
Contributor

Navidem commented Jun 14, 2022

Yeah it should take more than 1 hour, but less than 2. You see no progress? what's the log/output and what about the processes running? Also make sure to have this update ossf/fuzz-introspector#328 -- am not 100% sure if it's needed but it could be.

Went on successfully after removing the previous oss-fuzz dir, and re-building images.

Copy link
Contributor

@Navidem Navidem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Navidem
Copy link
Contributor

Navidem commented Jun 14, 2022

/gcbrun trial_build.py skcms --sanitizer address --fuzzing-engine libfuzzer

@Navidem Navidem merged commit a972a93 into google:master Jun 14, 2022
MartinPetkov pushed a commit to MartinPetkov/oss-fuzz that referenced this pull request Aug 15, 2022
* infra: add proj name to env for fuzz introspector

Depends on ossf/fuzz-introspector#327

Ref: ossf/fuzz-introspector#317

* lint fix

* update introspector commit

Co-authored-by: Navidem <navid.emamdoost@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants