Set PROJECT_NAME env and update download_corpora_step() #7873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun trial_build.py skcms --sanitizer address --fuzzing-engine libfuzzer |
oliverchang
approved these changes
Jun 16, 2022
| @@ -111,8 +111,7 @@ def get_build_steps( # pylint: disable=too-many-locals, too-many-arguments | |||
| env = build_project.get_env(project.fuzzing_language, build) | |||
| build_steps.append( | |||
| build_project.get_compile_step(project, build, env, config.parallel)) | |||
| download_corpora_steps = build_lib.download_corpora_steps( | |||
| project.name, testing=config.testing) | |||
| download_corpora_steps = build_lib.download_corpora_steps(project.name) | |||
There was a problem hiding this comment.
Ah was this code broken when I committed it?
There was a problem hiding this comment.
Yes, I got this failing when trying to run build_and_run_coverage.py locally.
MartinPetkov
pushed a commit
to MartinPetkov/oss-fuzz
that referenced
this pull request
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_lib.download_corpora_steps()PROJECT_NAMEenv var