Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goblin: initial integration #8646

Closed
wants to merge 2 commits into from
Closed

goblin: initial integration #8646

wants to merge 2 commits into from

Conversation

manunio
Copy link
Contributor

@manunio manunio commented Sep 30, 2022 •
edited

Hi goblin is cross-platform binary parsing crate, written in Rust.

@manunio manunio mentioned this pull request Sep 30, 2022
Open
@manunio
Copy link
Contributor Author

manunio commented Oct 24, 2022

hi @manunio i would prefer not to sign up my email for this service, but if you feel like it and don't mind it, I don't see a problem with you signing up and either opening issues you find here or perhaps sending me an email if something serious is discovered :)
m4b/goblin#334 (comment)

Hi @jonathanmetzman @Navidem received permission from upstream, please review this pr.

@manunio manunio marked this pull request as ready for review October 24, 2022 06:59
jonathanmetzman
jonathanmetzman approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

projects/goblin/Dockerfile
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder-rust
RUN apt-get update && apt-get install -y make autoconf automake libtool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you actually need this line?

@jonathanmetzman
Copy link
Contributor

hi @manunio i would prefer not to sign up my email for this service, but if you feel like it and don't mind it, I don't see a problem with you signing up and either opening issues you find here or perhaps sending me an email if something serious is discovered :)
m4b/goblin#334 (comment)

Hi @jonathanmetzman @Navidem received permission from upstream, please review this pr.

Not sure about this one as upstream doesn't really want it.

@manunio manunio closed this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmetzman jonathanmetzman jonathanmetzman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manunio @jonathanmetzman