feat: create --format flag
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another-rex
approved these changes
Jan 22, 2023
another-rex
reviewed
Jan 22, 2023
hayleycd
pushed a commit
that referenced
this pull request
Mar 9, 2023
julieqiu
pushed a commit
to julieqiu/osv-scanner
that referenced
this pull request
May 2, 2023
* feat: create `--format` flag * fix: mark `--json` as deprecated
julieqiu
pushed a commit
to julieqiu/osv-scanner
that referenced
this pull request
May 2, 2023
* feat: create `--format` flag * fix: mark `--json` as deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #156 and related to #85.
I've gone with
--formatinstead of--outputbecause it seems more common (looking at CLI tools like ESLint, Rubocop,bundler-audit, rspec, Terminus) and also because--outputtends to match the flag used by some CLI tools for "output to file" such as ESLint and cURL which the scanner might decide to support one day.I've also kept it simple for now since there's only a couple of formats supported - in future it might make sense to employ enum / const types and look at some fancy map similar to what
lockfilehas for its parsers, but I don't think that's needed here yet.(this'll need rebasing when #161 is landed)