Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add withdrawn and fix time serialization to conform to the schema. #424

Merged
merged 8 commits into from
Jun 27, 2023
Merged

Add withdrawn and fix time serialization to conform to the schema. #424

merged 8 commits into from
Jun 27, 2023

Conversation

calebbrown
Copy link
Contributor

  • withdrawn timestamp does not exist in the model - add it to the model.
  • fix the timestamp serialization to ensure published and withdrawn are only present when the value is not zero
  • fix timestamp serialization to use RFC3339 for JSON (it uses RFC3339Nano by default)
  • fix the timestamps to be normalized to UTC as per the schema

@calebbrown
Add withdrawn and fix time serialization to conform to the schema.
e596787 
Signed-off-by: Caleb Brown <calebbrown@google.com>
@calebbrown
Fix the comment to match the func.
b3b8e48 
Signed-off-by: Caleb Brown <calebbrown@google.com>
@G-Rath
Copy link
Collaborator

G-Rath commented Jun 27, 2023

Note this will conflict with #423

@calebbrown
Fix lint warnings
b1a56e5 
Signed-off-by: Caleb Brown <calebbrown@google.com>
@calebbrown
Fix parallel test
d04bda6 
Signed-off-by: Caleb Brown <calebbrown@google.com>
@calebbrown
More lint fixes
0d790a7 
Signed-off-by: Caleb Brown <calebbrown@google.com>
@calebbrown
Lint warning
ceee749 
Signed-off-by: Caleb Brown <calebbrown@google.com>
@calebbrown calebbrown mentioned this pull request Jun 27, 2023
Merged
@calebbrown
Copy link
Contributor Author

Note this will conflict with #423

Thanks! Fixed :)

oliverchang
oliverchang approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Caleb!

pkg/models/vulnerability.go Show resolved Hide resolved
@oliverchang oliverchang merged commit 84ae17f into google:main Jun 27, 2023
5 checks passed
@calebbrown calebbrown deleted the osv_model_updates3 branch June 27, 2023 07:03
@Porkepix Porkepix mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverchang oliverchang oliverchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebbrown @G-Rath @oliverchang