Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make models tests their own package #423

Merged
merged 1 commit into from
Jun 27, 2023
Merged

test: make models tests their own package #423

merged 1 commit into from
Jun 27, 2023

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jun 27, 2023

This reduces the diff with #183 a bit, and is good practice

@G-Rath G-Rath mentioned this pull request Jun 27, 2023
Merged
@calebbrown
Copy link
Contributor

I'll update PR #424 after this one is merged.

another-rex
another-rex approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@another-rex another-rex merged commit d378b92 into google:main Jun 27, 2023
@G-Rath G-Rath deleted the make-tests-public branch June 27, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebbrown calebbrown calebbrown approved these changes

@another-rex another-rex another-rex approved these changes

@oliverchang oliverchang Awaiting requested review from oliverchang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@G-Rath @calebbrown @another-rex