Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name field to sarif rule output #600

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

another-rex
Copy link
Collaborator

Fixes #599

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #600 (6956722) into main (6bc8b22) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   80.61%   80.61%           
=======================================
  Files          78       78           
  Lines        5333     5334    +1     
=======================================
+ Hits         4299     4300    +1     
  Misses        866      866           
  Partials      168      168           
Files Coverage Δ
internal/output/sarif.go 90.42% <100.00%> (+0.05%) ⬆️

@another-rex another-rex merged commit c00f630 into google:main Oct 24, 2023
8 checks passed
another-rex added a commit to another-rex/osv-scanner that referenced this pull request Oct 26, 2023
* Add name field to sarif rule output (google#600)

Fixes google#599

* fix: trim leading and trailing newlines off SARIF output (google#606)

I don't know a lot about SARIF so maybe these are required but that
would be surprising to me whereas trimming these off make it a bit
consistent for editors and such.

Obviously if these are required then lets close this PR

* Update release pipeline (google#602)

Update the release pipeline to have it be manually triggered, and create
a tag itself if checks and scans are successful.

It looks something like this:

![image](https://github.com/google/osv-scanner/assets/106129829/8258a7d3-3438-46f7-82cd-49c2b4056ecf)

The release doc has been updated to follow this new workflow.

* chore: don't trim trailing whitespace on fixture snapshots (google#608)

This makes it easier to work with for IDEs

* Prepare for 1.4.2 release (google#609)

* Update jekyll feed, for some reason renovatebot can't figure out how to update this

* Fix documentation for github action

* Set upload tag name

---------

Co-authored-by: Gareth Jones <Jones258@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SARIF output is missing names on rules breaking GitLab parsing
3 participants