fix: trim leading and trailing newlines off SARIF output #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #606 +/- ##
=======================================
Coverage 80.61% 80.61%
=======================================
Files 78 78
Lines 5334 5334
=======================================
Hits 4300 4300
Misses 866 866
Partials 168 168
|
another-rex
approved these changes
Oct 24, 2023
😞 |
|
Oh, did you used to just press the delete branch button? |
|
Yeah that's what I've always been doing on this repo and e.g. what I did after posting that screenshot - I guess you were right it just doesn't work across forks 🤷 |
another-rex
added a commit
to another-rex/osv-scanner
that referenced
this pull request
Oct 26, 2023
* Add name field to sarif rule output (google#600) Fixes google#599 * fix: trim leading and trailing newlines off SARIF output (google#606) I don't know a lot about SARIF so maybe these are required but that would be surprising to me whereas trimming these off make it a bit consistent for editors and such. Obviously if these are required then lets close this PR * Update release pipeline (google#602) Update the release pipeline to have it be manually triggered, and create a tag itself if checks and scans are successful. It looks something like this:  The release doc has been updated to follow this new workflow. * chore: don't trim trailing whitespace on fixture snapshots (google#608) This makes it easier to work with for IDEs * Prepare for 1.4.2 release (google#609) * Update jekyll feed, for some reason renovatebot can't figure out how to update this * Fix documentation for github action * Set upload tag name --------- Co-authored-by: Gareth Jones <Jones258@Gmail.com>
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Oct 26, 2023
I don't know a lot about SARIF so maybe these are required but that would be surprising to me whereas trimming these off make it a bit consistent for editors and such. Obviously if these are required then lets close this PR
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Oct 27, 2023
I don't know a lot about SARIF so maybe these are required but that would be surprising to me whereas trimming these off make it a bit consistent for editors and such. Obviously if these are required then lets close this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know a lot about SARIF so maybe these are required but that would be surprising to me whereas trimming these off make it a bit consistent for editors and such.
Obviously if these are required then lets close this PR