Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create shorter redirect link format for vulnerabilities #930

Closed
oliverchang opened this issue Dec 20, 2022 · 4 comments · Fixed by #952
Closed

Create shorter redirect link format for vulnerabilities #930

oliverchang opened this issue Dec 20, 2022 · 4 comments · Fixed by #952
Labels
enhancement New feature or request infra infrastructure bugs/FRs

Comments

@oliverchang
Copy link
Collaborator

e.g. https://osv.dev/v/PYSEC-foo should redirect to the full https://osv.dev/vulnerability/PYSEC-foo.

This can help with osv-scanner's human readable output, where horizontal space is a premium.
@oliverchang oliverchang added enhancement New feature or request infra infrastructure bugs/FRs labels Dec 20, 2022
@andrewpollock
Copy link
Contributor

The number of times I've tried and failed to use just osv.dev/id, could we support that for maximum URL brevity? Feels more intuitive.

@oliverchang
Copy link
Collaborator Author

Yeah that's certainly another possibility, just wonder if it creates any complexities in the future since it introduces potential routing clashes with other top level OSV.dev pages.

@andrewpollock
Copy link
Contributor

Yes, there's a (small, IMO) risk, given all of the IDs should be fairly unambiguously regex-able...

oliverchang added a commit that referenced this issue Jan 6, 2023
@oliverchang
Create short redirect link format for vulnerabilities.
16aa46c 
https://osv.dev/VULN-ID would redirect to
https://osv.dev/vulnerability/VULN-ID, if VULN-ID exists.

Fixes #930.
oliverchang added a commit that referenced this issue Jan 6, 2023
@oliverchang
Create short redirect link format for vulnerabilities.
578f5ba 
https://osv.dev/VULN-ID would redirect to
https://osv.dev/vulnerability/VULN-ID, if VULN-ID exists.

Fixes #930.
@oliverchang oliverchang mentioned this issue Jan 6, 2023
Merged
oliverchang added a commit that referenced this issue Jan 9, 2023
@oliverchang
Create short redirect link format for vulnerabilities. (#952)
b8f3e6e 
https://osv.dev/VULN-ID would redirect to
https://osv.dev/vulnerability/VULN-ID, if VULN-ID exists.

Fixes #930.
@andrewpollock
Copy link
Contributor

One observation: this doesn't work for aliases, and I wonder whether it could/should? In my opinion it would be much more delightful for our users if it did...

e.g. I can go the long way around to search for CVE-2013-5823, which turns out to be an alias for GHSA-8gwc-x7mg-7p7p, but I can't go to osv.dev/CVE-2013-5823 successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request infra infrastructure bugs/FRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create short redirect link format for vulnerabilities. google/osv.dev
2 participants
@oliverchang @andrewpollock