Create short redirect link format for vulnerabilities. #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://osv.dev/VULN-ID would redirect to https://osv.dev/vulnerability/VULN-ID, if VULN-ID exists. Fixes #930.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| _VALID_BLOG_NAME = re.compile(r'^[\w-]+$') | ||
| _WORD_CHARACTERS_OR_DASH = re.compile(r'^[\w-]+$') | ||
| _VALID_BLOG_NAME = _WORD_CHARACTERS_OR_DASH | ||
| _VALID_VULN_ID = _WORD_CHARACTERS_OR_DASH |
There was a problem hiding this comment.
You could tighten this regex up a bit more to say ^\w+-[\w-]+$ and be less likely to match on things that aren't actually intended to be vulnerability IDs now, or in the future...
(aside: I can't find any signs of LBSEC IDs, even though they get a mention in the schema docs)
There was a problem hiding this comment.
Yeah, but it does add a tad bit more complexity (adding a similar but different regex) for little benefit (since we ultimately validate the ID to exist in our DB), and this is a rare edge case that would save us a single Datastore entity read.
I'll keep this as is in the interests of simplicity.
andrewpollock
approved these changes
Jan 6, 2023
another-rex
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://osv.dev/VULN-ID would redirect to
https://osv.dev/vulnerability/VULN-ID, if VULN-ID exists.
Fixes #930.