Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layout shift in list page #2349

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Fix layout shift in list page #2349

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
021a987
Declare the height of search box to avoid layout shift
zahraaalizadeh Jun 26, 2024
48130b2
Declare the size of published sorted arrow
zahraaalizadeh Jun 26, 2024
c0d8d57
Declare the height of text fields before turbo frame
zahraaalizadeh Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions gcp/appengine/frontend3/src/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ pre {
$left-padding: 40px;
display: flex;
padding: 34px $left-padding;
height: 98px;

.logo {
$logo-width: 53px;
Expand Down Expand Up @@ -316,6 +317,7 @@ pre {
.list-page {
.title {
font-size: 20px;
height: 25px;
}

.ecosystem-buttons {
Expand Down Expand Up @@ -370,6 +372,7 @@ pre {
padding: 10px 20px;
background: #696969;
border-radius: 999px;
height: 38px;

.ecosystem-count {
font-weight: bold;
Expand Down Expand Up @@ -410,6 +413,7 @@ pre {
--md-sys-color-primary: $osv-text-color;
--md-sys-color-on-surface: $osv-text-color;
--md-sys-color-on-surface-variant: $osv-text-color;
height: 56px;

// Make the inner search field full-width.
.query-field {
Expand Down Expand Up @@ -437,8 +441,8 @@ pre {

// Hax: Make @material/md-icon-button play well with @material/data-table.
md-icon-button.mdc-data-table__sort-icon-button {
width: auto;
height: auto;
width: 18px;
height: 18px;
--md-icon-button-icon-size: 18px;
--md-icon-button-icon-color: $osv-text-color;
--md-icon-button-disabled-icon-color: $osv-grey-600;
Expand Down
Loading