Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add six to install_requires #77

Closed
wants to merge 1 commit into from
Closed

Add six to install_requires #77

wants to merge 1 commit into from

Conversation

koobs
Copy link

@koobs koobs commented Sep 7, 2019

six is a documented dependency, add it to install_requires accordingly

six is a documented dependency, add it to install_requires accordingly
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Sep 7, 2019
six is a documented [1][2] dependency, add it to install_requires
accordingly.

While I'm here, add a test target and patch setup.py so it doesn't run
the tests twice.

[1] https://github.com/google/pasta#dependencies
[2] google/pasta#77

Approved by:	portmgr (blanket(s): missing dependencies, framework)
MFH:		2019Q3


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@511404 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Sep 7, 2019
six is a documented [1][2] dependency, add it to install_requires
accordingly.

While I'm here, add a test target and patch setup.py so it doesn't run
the tests twice.

[1] https://github.com/google/pasta#dependencies
[2] google/pasta#77

Approved by:	portmgr (blanket(s): missing dependencies, framework)
MFH:		2019Q3
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request Sep 7, 2019
six is a documented [1][2] dependency, add it to install_requires
accordingly.

While I'm here, add a test target and patch setup.py so it doesn't run
the tests twice.

[1] https://github.com/google/pasta#dependencies
[2] google/pasta#77

Approved by:	portmgr (blanket(s): missing dependencies, framework)
MFH:		2019Q3


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@511404 35697150-7ecd-e111-bb59-0022644237b5
@soupytwist
Copy link
Collaborator

Thanks for adding this! If you accept the CLA (https://cla.developers.google.com/) I can merge.

@koobs
Copy link
Author

koobs commented Sep 10, 2019

@soupytwist Hi Nick! I'm not too keen to sign a CLA at the moment, especially for such a small, metadata only change, but happy for you to close this, replace it with a PR of your own, or create an issue instead. If there are better alternatives, I'm all ears

@soupytwist
Copy link
Collaborator

I've added this in the latest commit. Thanks for your help!

@soupytwist soupytwist closed this Nov 4, 2019
@koobs
Copy link
Author

koobs commented Nov 5, 2019

@soupytwist Thank you Nick, my pleasure :)

svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this pull request Jan 10, 2024
six is a documented [1][2] dependency, add it to install_requires
accordingly.

While I'm here, add a test target and patch setup.py so it doesn't run
the tests twice.

[1] https://github.com/google/pasta#dependencies
[2] google/pasta#77

Approved by:	portmgr (blanket(s): missing dependencies, framework)
MFH:		2019Q3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants