-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add six to install_requires #77
Conversation
six is a documented dependency, add it to install_requires accordingly
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
six is a documented [1][2] dependency, add it to install_requires accordingly. While I'm here, add a test target and patch setup.py so it doesn't run the tests twice. [1] https://github.com/google/pasta#dependencies [2] google/pasta#77 Approved by: portmgr (blanket(s): missing dependencies, framework) MFH: 2019Q3 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@511404 35697150-7ecd-e111-bb59-0022644237b5
six is a documented [1][2] dependency, add it to install_requires accordingly. While I'm here, add a test target and patch setup.py so it doesn't run the tests twice. [1] https://github.com/google/pasta#dependencies [2] google/pasta#77 Approved by: portmgr (blanket(s): missing dependencies, framework) MFH: 2019Q3
six is a documented [1][2] dependency, add it to install_requires accordingly. While I'm here, add a test target and patch setup.py so it doesn't run the tests twice. [1] https://github.com/google/pasta#dependencies [2] google/pasta#77 Approved by: portmgr (blanket(s): missing dependencies, framework) MFH: 2019Q3 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@511404 35697150-7ecd-e111-bb59-0022644237b5
Thanks for adding this! If you accept the CLA (https://cla.developers.google.com/) I can merge. |
@soupytwist Hi Nick! I'm not too keen to sign a CLA at the moment, especially for such a small, metadata only change, but happy for you to close this, replace it with a PR of your own, or create an issue instead. If there are better alternatives, I'm all ears |
I've added this in the latest commit. Thanks for your help! |
@soupytwist Thank you Nick, my pleasure :) |
six is a documented [1][2] dependency, add it to install_requires accordingly. While I'm here, add a test target and patch setup.py so it doesn't run the tests twice. [1] https://github.com/google/pasta#dependencies [2] google/pasta#77 Approved by: portmgr (blanket(s): missing dependencies, framework) MFH: 2019Q3
six is a documented dependency, add it to install_requires accordingly