Add pipeline parallelism for Grok #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
paxml/tasks/lm/model_params.py
Outdated
| @@ -834,8 +834,8 @@ def task(self) -> pax_fiddle.Config[tasks_lib.SingleTask]: | |||
| assert self.NUM_STAGES is not None | |||
| assert self.NUM_LAYERS % (self.NUM_STAGES * self.CIRCULAR_REPEAT) == 0 | |||
| assert self.NUM_MICROBATCHES is not None or self.MICROBATCH_SIZE is not None | |||
| assert self.ICI_MESH_SHAPE is not None and len(self.ICI_MESH_SHAPE) == 4 | |||
| assert self.DCN_MESH_SHAPE is not None and len(self.DCN_MESH_SHAPE) == 4 | |||
| assert self.ICI_MESH_SHAPE is not None and len(self.ICI_MESH_SHAPE) >= 4 | |||
There was a problem hiding this comment.
Can we put this assert > 4 behind the USE_EXPERT_PARALLEL flag?
Someone using regular PP with an incorrect mesh should get stopped by these assertions.
There was a problem hiding this comment.
Sounds good, I've updated the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.