Rollup of changes in google3 using copybara #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 160971937
aalexand
approved these changes
Jul 12, 2017
aalexand
reviewed
Jul 12, 2017
| @@ -192,7 +172,7 @@ bool Builder::CheckValid(const Profile &profile) { | |||
| for (const auto &sample : profile.sample()) { | |||
| if (sample.value_size() != sample_type_len) { | |||
| std::cerr << "Found sample with " << sample.value_size() | |||
| << " values, expecting " << sample_type_len; | |||
| << " values, expecting " << sample_type_len; | |||
There was a problem hiding this comment.
The leading space before "<<" is weird here.
aalexand
reviewed
Jul 12, 2017
| @@ -228,7 +208,7 @@ bool Builder::Finalize() { | |||
| for (auto &sample : *profile_->mutable_sample()) { | |||
| // Copy sample locations into a temp vector, and then clear and | |||
| // repopulate it with the corresponding location IDs. | |||
| const auto addresses = sample.location_id(); | |||
| const RepeatedField<uint64> addresses = sample.location_id(); | |||
There was a problem hiding this comment.
I am curious what was the reason for replacing "auto" with explicit type here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.