Use the library name from the POM file of the dependency #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2021
Keep track of already added licenses and reuse their offsets
Merged
caller9
requested changes
Aug 12, 2021
...censes-plugin/src/main/groovy/com/google/android/gms/oss/licenses/plugin/LicensesTask.groovy
Outdated
Show resolved
Hide resolved
...censes-plugin/src/main/groovy/com/google/android/gms/oss/licenses/plugin/LicensesTask.groovy
Outdated
Show resolved
Hide resolved
|
I will fix the tests asap, tbh I forgot to run them |
|
I fixed the tests and your remarks. There was one broken test file ( Thank you for the review! |
caller9
reviewed
Aug 13, 2021
...censes-plugin/src/test/java/com/google/android/gms/oss/licenses/plugin/LicensesTaskTest.java
Show resolved
Hide resolved
...censes-plugin/src/test/java/com/google/android/gms/oss/licenses/plugin/LicensesTaskTest.java
Outdated
Show resolved
Hide resolved
...censes-plugin/src/main/groovy/com/google/android/gms/oss/licenses/plugin/LicensesTask.groovy
Show resolved
Hide resolved
|
Changed the code and merged my other PR into this one. I'm looking forward new feedback |
caller9
approved these changes
Aug 25, 2021
|
@caller9 when I see this correctly then has my patch already landed in multiple Google Apps like the PlayStore, is there any timeframe when I can expect to see this in a public release? |
|
My patch went live in 0.10.5 on February 28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to have the clean name of the dependency if set in the POM file. My PR will use the name and will fallback when the name tag is not set in the POM file to the artifact group and artifact id.
Fixes #184