Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep track of already added licenses and reuse their offsets #190

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Keep track of already added licenses and reuse their offsets #190

merged 2 commits into from
Aug 25, 2021

Conversation

rekire
Copy link
Contributor

@rekire rekire commented Jul 3, 2021

As the title says I keep track of the already added licenses and avoid to duplicates the licenses in third_party_licenses. In one of my projects I was able to reduce the size of third_party_licenses from 633KB to 237KB.

Fixes #187

@rekire rekire mentioned this pull request Aug 8, 2021
Merged
@caller9
Copy link
Collaborator

caller9 commented Aug 12, 2021

This PR is superseded by #191 as it includes these changes.

@rekire
Copy link
Contributor Author

rekire commented Aug 13, 2021

@caller9 no this is not superseded by #191. In fact that PR might cause a merge conflict when I don't mix up something. I tried to keep both PRs separately.

@caller9 caller9 mentioned this pull request Aug 13, 2021
Merged
@caller9 caller9 merged commit d2851a3 into google:master Aug 25, 2021
@rekire rekire deleted the deduplicate_licenses branch August 25, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dublicated licenses in the third_party_licenses file
2 participants
@rekire @caller9