Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With multiple input perf.data files, some files are recognized as either empty input files or unrecognized profile format #500

Closed
harveylihr opened this issue Nov 20, 2019 · 2 comments · Fixed by #565
Closed

With multiple input perf.data files, some files are recognized as either empty input files or unrecognized profile format #500

harveylihr opened this issue Nov 20, 2019 · 2 comments · Fixed by #565
Assignees
@kalyanac

Comments

@harveylihr
Copy link

When I run pprof with multiple perf.data files (e.g. pprof -top *.data), some files will be randomly recognized as empty input files or in unrecognized profile format.
However, when I run pprof with those "wrong" files, it can successfully generate report.

pprof.log
@nolanmar511
Copy link
Contributor

nolanmar511 commented Nov 20, 2019 •
edited
Loading

Can you provide more details on how to reproduce this?

@harveylihr
Copy link
Author

harveylihr commented Nov 20, 2019 •
edited
Loading

Can you provide more details on how to reproduce this?

Please find 10 raw perf.data in the attached file, when using pprof to convert & view them (e.g. pprof -top *.data), some perf.data files cannot be recognized.
test_perfdata.zip
It happens very frequently, basically every time I tried with, let's say, more than five perf.data files.

@aalexand aalexand assigned aalexand and kalyanac and unassigned aalexand Nov 22, 2019
aalexand added a commit to aalexand/pprof that referenced this issue Oct 4, 2020
@aalexand
Fix a race in temp file creation.
90badd5 
Fixes google#500.
aalexand added a commit to aalexand/pprof that referenced this issue Oct 4, 2020
@aalexand
Fix a race in temp file creation.
0c5f2a9 
The added test fails before the fix and passes after.

Fixes google#500.
@aalexand aalexand mentioned this issue Oct 4, 2020
Merged
aalexand added a commit to aalexand/pprof that referenced this issue Oct 4, 2020
@aalexand
Fix a race in temp file creation.
13f5fc0 
The added test fails before the fix and passes after.

Fixes google#500.
aalexand added a commit to aalexand/pprof that referenced this issue Oct 4, 2020
@aalexand
Fix a race in temp file creation.
2c1365a 
The added test fails before the fix and passes after.

Fixes google#500.
aalexand added a commit to aalexand/pprof that referenced this issue Oct 6, 2020
@aalexand
Fix a race in temp file creation.
8d5037f 
The added test fails before the fix and passes after.

Fixes google#500.
aalexand added a commit to aalexand/pprof that referenced this issue Oct 6, 2020
@aalexand
Fix a race in temp file creation.
a13cf9d 
The added test fails before the fix and passes after.

Fixes google#500.
aalexand added a commit that referenced this issue Oct 6, 2020
@aalexand
Fix a race in temp file creation. (#565)
29d1258 
The added test fails before the fix and passes after.

Fixes #500.
gmarin13 pushed a commit to gmarin13/pprof that referenced this issue Dec 17, 2020
@aalexand
Fix a race in temp file creation. (google#565)
16567e9 
The added test fails before the fix and passes after.

Fixes google#500.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalyanac kalyanac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a race in temp file creation. aalexand/pprof
4 participants
@aalexand @kalyanac @harveylihr @nolanmar511