Parse numeric labels with a value of zero if units are specified. #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, a numeric label with a value of zero is interpreted as an empty label which will be ignored during parsing. However, a zero value can be a valid label value. Instead of ignoring it altogether, parse it as a zero-valued numeric label if num_unit is set.
xyzsam
changed the title
nolanmar511
approved these changes
Apr 6, 2021
|
@xyzsam @nolanmar511 It looks like we didn't add a test here? Looking at the *_test.go file it looks like the test data was updated, but I don't see an actual check added. I could be missing something. |
Oh, I guess it checks the whole serialize <-> deserialize loop? I assume the test failed before the fix? |
copybara-service bot
pushed a commit
to google/tcmalloc
that referenced
this pull request
Oct 10, 2022
google/pprof#619 interprets a non-zero unit as a present field, even if proto3 causes the field to not be populated on the wire. PiperOrigin-RevId: 480082958 Change-Id: I68ab12997cbdb31274ccc8ce9316b3e2dbd104b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, a numeric label with a value of zero is interpreted as an
empty label which will be ignored during parsing. However, a zero value
can be a valid label value. Instead of ignoring it altogether, parse it
as a zero-valued numeric label if num_unit is set.