Require config packages in CMake. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the system has a Find$DEP.cmake available, CMake might prefer that definition to ours. It almost certainly won't contain libraries for Android, and it may not even expose the same interface. It may not necessarily find *any* libraries at all. Enforce that a config-style package is loaded rather than the module-style package (see https://cmake.org/cmake/help/latest/command/find_package.html).
enh-google
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the system has a Find$DEP.cmake available, CMake might prefer that
definition to ours. It almost certainly won't contain libraries for
Android, and it may not even expose the same interface. It may not
necessarily find any libraries at all.
Enforce that a config-style package is loaded rather than the
module-style package (see
https://cmake.org/cmake/help/latest/command/find_package.html).
/gcbrun