This repository has been archived by the owner on Dec 9, 2023. It is now read-only.
[null-safety] migrate package:process to _almost_ null safety #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
approved these changes
Jul 29, 2020
| path: ^1.5.1 | ||
| platform: '>=1.0.1' | ||
|
|
||
| dev_dependencies: | ||
| test: ^1.0.0 | ||
|
|
||
| environment: | ||
| sdk: '>=2.0.0 <3.0.0' | ||
| sdk: '>=2.9.0 <3.0.0' |
There was a problem hiding this comment.
Ahh right, we switched versions. 😄
There was a problem hiding this comment.
actually we're currently at 2.9 and the next version is null safety. I think flutter is on an allowlist to specify a 2.10 constraint which this package isn't on yet
| @@ -53,15 +54,14 @@ class ProcessWrapper implements io.Process { | |||
| /// | |||
| /// The future returned here will complete with the exit code of the process. | |||
| Future<int> get done async { | |||
| int result; | |||
| late int result; | |||
tvolkert
approved these changes
Jul 29, 2020
|
Why was record/replay removed? README still advertises the package as having this feature. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to null-safety, except for the path/file/platform dependencies which are not yet migrated.
Removes record/replay functionality.