Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all() with a generic tuple containing 4 types #61

Closed
EthanLozano opened this issue Jul 21, 2018 · 1 comment
Closed

all() with a generic tuple containing 4 types #61

EthanLozano opened this issue Jul 21, 2018 · 1 comment

Comments

@EthanLozano
Copy link
Contributor

The all() function currently supports tuples with up to 3 different types. Does it make sense to have an all() function that supports tuples with up to 4 types? I realize that if 4 types are supported, then someone might ask for 5 types! So, I understand if this request is denied.

As a workaround, I'm composing all within all, which isn't pretty: all(promise1, all(promise2, promise3, promise4)). FYI, though I'm using 4 promises, my code rarely (if ever) makes 4 I/O requests due to caching.

@shoumikhin
Copy link
Contributor

Hi Ethan, we do welcome pull requests :)
I think 4 or even 5 values for ‘all’ should be fine.

EthanLozano added a commit to EthanLozano/promises that referenced this issue Jul 21, 2018
EthanLozano added a commit to EthanLozano/promises that referenced this issue Jul 21, 2018
@ghost ghost closed this as completed in #62 Jul 26, 2018
ghost pushed a commit that referenced this issue Jul 26, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants