Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar type refs #204

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Scalar type refs #204

merged 2 commits into from
Jul 30, 2018

Conversation

inanna-malick
Copy link
Contributor

@inanna-malick inanna-malick commented Jul 27, 2018

This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

@judah
Copy link
Collaborator

judah commented Jul 30, 2018

Looks good! Can you please also add a link to the docs index, so it shows up in google.github.io/proto-lens?
https://github.com/google/proto-lens/blob/master/docs/index.md

@judah judah merged commit c84535d into google:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants