Start work on generated code for encoding/decoding proto messages. #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stubs out new methods in the Message class for decoding and encoding.
By generating the implementations rather than going through the reified
FieldDescriptor, we should ultimately get much faster code.
Currently, the implementations are trivial (e.g.,
buildMessage = const ""
) andalso named
unfinished{Parse,Build}Message
.The code for the old, "reflected" encoding/decoding (i.e., using
FieldDescriptor
) has been moved to a new module namespaceData.ProtoLens.Encoding.Reflected
. It is still used byData.ProtoLens.Encoding
by default. A Cabal flaggenerated-encoding
lets`Data.ProtoLens.Encoding use the new implementation.
My intention is to finish this implementation and delete the old code before
making a new major release of proto-lens. In the meantime, this setup should
make it easier to implement the new API as a series of distinct PRs.
I changed CI to build the tests and benchmarks with the new API, but not to
actually run them (since they don't pass).
This change is