Fix the handling of packed repeated fields (#38). #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
judah
commented
Dec 28, 2016
judah
commented
- Don't emit empty packed fields during encoding.
- Allow parsing packed fields as unpacked and vice versa.
- Proto3 repeated fields are packed by default.
- Don't emit empty packed fields during encoding. - Allow parsing packed fields as unpacked and vice versa. - Proto3 repeated fields are packed by default.
awpr
approved these changes
Jan 9, 2017
| getSimpleVal = do | ||
| Equal <- equalWireTypes name fieldWt wt | ||
| get val | ||
| -- Get a block of packed values, reversed. | ||
| getPackedVals :: w ~ B.ByteString => Either String [a] |
There was a problem hiding this comment.
Would this be simpler as "getPackedVals :: B.ByteString -> Either String [a]" and then the type equality can be implicit at the call site (in the RepeatedField case below)?
There was a problem hiding this comment.
It turned out GHC can infer these types (maybe due to the refactor you suggested below), so I just removed the type signature.
| -- depending on how it was encoded. | ||
| -- Note that if fieldWt is Lengthy (e.g., "string" or | ||
| -- message) we should always parse it as unpacked. | ||
| | Right Equal <- equalWireTypes name wt fieldWt -> do |
There was a problem hiding this comment.
Alternatively (ha), "RepeatedField _ f -> getPackedVals <|> getUnpackedVals <|> fail ..." and keep the "equalWireTypes" calls in the helper functions.
added 5 commits
January 16, 2017 13:56
This fixed a regression of about 10% in some of the decoding benchmarks.
avdv
pushed a commit
to avdv/proto-lens
that referenced
this pull request
Aug 9, 2023
ylecornec
pushed a commit
to ylecornec/proto-lens
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.