Pass sourcesets using TaskInputs.files, not .file #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangkun83
reviewed
Oct 18, 2017
| @@ -55,6 +55,6 @@ buildscript { | |||
|
|
|||
| where: | |||
| androidPluginVersion << ["2.2.0", "2.2.0", "3.0.0-alpha7"] | |||
| gradleVersion << ["2.14.1", "3.0", "4.1-milestone-1"] | |||
| gradleVersion << ["2.14.1", "3.0", "4.1-milestone-1", "4.3-rc-2"] | |||
There was a problem hiding this comment.
The 4.1 milestone should probably be changed to 4.1
| @@ -63,7 +63,7 @@ class Utils { | |||
|
|
|||
| static void addFilesToTaskInputs(Project project, TaskInputs inputs, Object files) { | |||
| if (compareGradleVersion(project, "3.0") >= 0) { | |||
| inputs.file(files).skipWhenEmpty() | |||
| inputs.files(files).skipWhenEmpty() | |||
There was a problem hiding this comment.
Wow, glad to see it can be fixed in such a clean way.
There was a problem hiding this comment.
@zpencer Had to dig as deep as this diff to solve my project's problem: org.gradle.api.internal.tasks.DefaultTaskOutputs@1cc16f4b' specified for property '$1' cannot be converted to a file. Thanks a lot!
P.S.: if you know how to start debugging such a problem (interested in how you did it), please tell me.
zpencer
force-pushed
the
taskinput-files
branch
from
4f23fa4
to
0c11d73
Compare
|
LGTM! Thanks @zpencer! |
zhangkun83
pushed a commit
to zhangkun83/protobuf-gradle-plugin-1
that referenced
this pull request
Nov 7, 2018
This is deprecated in gradle 4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskInputs.file can only accept real files, not sourcesets:
https://discuss.gradle.org/t/gradle-4-3-rc1-is-available-for-testing/24415/16