Generic generated message #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szakarias
reviewed
Jan 14, 2019
| } | ||
|
|
||
| @override | ||
| // TODO: implement info_ |
|
|
||
| BuilderInfo(String messageName, {PackageName package = const PackageName('')}) | ||
| : qualifiedMessageName = "${package.prefix}$messageName"; | ||
| BuilderInfo(String messageName, {CreateBuilderFunc<M> builder, PackageName package = const PackageName('')}) |
There was a problem hiding this comment.
I don't think builder should be optional.
protobuf/test/builder_info_test.dart
Outdated
| @@ -5,17 +5,23 @@ | |||
| import 'package:protobuf/protobuf.dart'; | |||
| import 'package:test/test.dart'; | |||
|
|
|||
| class Foo extends GeneratedMessage<Foo> { | |||
| @override | |||
| // TODO: implement info_ | |||
protoc_plugin/pubspec.yaml
Outdated
| @@ -18,3 +18,7 @@ dev_dependencies: | |||
|
|
|||
| executables: | |||
| protoc-gen-dart: protoc_plugin | |||
|
|
|||
| dependency_overrides: | |||
szakarias
reviewed
Jan 14, 2019
|
Hello @sigurdm, any news for this PR? |
|
I want to do some measurements of the performance impact before landing this. |
|
I will not get time to land this in the short future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would solve #177 .
We have to measure the impact on existing codebases before landing this.