-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreplaced NamedType (pyi-error) #1229
Comments
I haven't pinned down the exact cause yet, but it seems to be a circular dependency issue - I'm seeing pytype generate .pyi-1 (intermediate) stubs. Likely what happened is that adding the Are you importing things from the neural_tangents/ submodules into
If so, one possible workaround for circular dependency issues is to have submodules import directly from each other rather than from |
Thanks a lot Rachel, indeed that's exactly what I was doing without realizing! I'll fix it soon and get back to you to confirm. |
Confirming - removing circular dependencies fixed the issue! |
Ok, I seem to have figured out half of the problem. Turns out the "Unreplaced NameType" errors were due to us not recognizing
I'll first get the fix for |
I also realized that the last time I changed is_package, I accidentally added an extra '.' in the .pickled extension for __init__ files (so they became __init__..pickled), but I did this both when unpickling and when checking the filename of the unpickled file, so it worked itself out. This has been fixed. For #1229. PiperOrigin-RevId: 460546845
Per suggestion in https://google.github.io/pytype/errors.html#pyi-error filing the bug here:
https://github.com/google/neural-tangents/actions/runs/2522284898
Error is
The change that cause it (google/neural-tangents@e28971c) was adding the new sub-module
into the module init file
https://github.com/google/neural-tangents/blob/main/neural_tangents/__init__.py
Any suggestions what I might be doing wrong? Thanks a lot!
The text was updated successfully, but these errors were encountered: