Dont call virtual method GetStatelessResetToken in ctor QuicSession::QuicSession
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slusnys
changed the title
GetStatelessResetToken in ctor QuicSession::QuicSession
- Virtual methods should not be called in constructors, as the virtual call mechanism is disabled. This might lead to a wrong tokens being returned.
slusnys
force-pushed
the
dont_call_virtual_GetStatelessResetToken_in_ctor
branch
from
9284a48
to
e17ebaf
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
…ation. This avoids virtual function GetStatelessResetToken be called in QuicSession constructor. This change is an internal landing of #26 authored by slusnys. Protected by FLAGS_quic_reloadable_flag_quic_delay_setting_stateless_reset_token. PiperOrigin-RevId: 485586079
|
Thank you. This proposal was merged internally with flag protection at db4dca8. |
|
FYI the flag has been deprecated at 0584360, this change is now complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuicSession class calls the virtual method GetStatelessResetToken() token in constructor
This might lead to a wrong tokens being returned.