Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CASE_RANGES with Character.to{Lower,Upper}Case(). #78

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

ringw
Copy link
Contributor

@ringw ringw commented Oct 18, 2018

No description provided.

@sjamesr
Copy link
Contributor

sjamesr commented Oct 18, 2018

The test failure is because GWT Character.to{Lower,Upper}Case does not have an overload that takes an int. Not sure right now what to do about it.

@ringw
Copy link
Contributor Author

ringw commented Oct 22, 2018

I got this working using a GWT super source. FYI, I can also deal with checking this in internally because it will need a special build rule.

@sjamesr
Copy link
Contributor

sjamesr commented Oct 22, 2018

I think if you squash these two commits into one, it'll make travis happy and we can check it in.

@ringw
Copy link
Contributor Author

ringw commented Oct 22, 2018

Done.

@coveralls
Copy link

coveralls commented Oct 22, 2018

Pull Request Test Coverage Report for Build 221

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 93.896%

Files with Coverage Reduction New Missed Lines %
/home/travis/build/google/re2j/java/com/google/re2j/UnicodeTables.java 1 99.86%
/home/travis/build/google/re2j/java/com/google/re2j/Unicode.java 10 72.0%
Totals Coverage Status
Change from base Build 217: -0.05%
Covered Lines: 2938
Relevant Lines: 3129

💛 - Coveralls

@sjamesr sjamesr merged commit 06d4a72 into google:master Oct 22, 2018
@sjamesr
Copy link
Contributor

sjamesr commented Oct 22, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants