Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ICU 70.1 #223

Closed
filmil opened this issue Nov 11, 2021 · 3 comments · Fixed by #234
Closed

Add support for ICU 70.1 #223

filmil opened this issue Nov 11, 2021 · 3 comments · Fixed by #234
Assignees
@filmil

Comments

@filmil
Copy link
Member

filmil commented Nov 11, 2021 •
edited
Loading

ICU 70.1 is released.

Make sure that rust_icu works with it.
@filmil filmil self-assigned this Nov 11, 2021
filmil added a commit to filmil/rust_icu that referenced this issue Nov 11, 2021
@filmil
Makes the necessary changes to have rust_icu compile with ICU 70.1
59f465a 
The two changes needed were timezone data version regex upgrade and a test touch-up.

This has been tested locally. Followup work will provide the builders.

Issue: google#223
@filmil filmil mentioned this issue Nov 11, 2021
Merged
filmil added a commit to filmil/rust_icu that referenced this issue Nov 11, 2021
@filmil
Makes the necessary changes to have rust_icu compile with ICU 70.1
5828a87 
The two changes needed were timezone data version regex upgrade and a test touch-up.

This has been tested locally. Followup work will provide the builders.

Issue: google#223
filmil added a commit to filmil/rust_icu that referenced this issue Nov 11, 2021
@filmil
Makes the necessary changes to have rust_icu compile with ICU 70.1
eac640d 
The two changes needed were timezone data version regex upgrade and a test touch-up.

This has been tested locally. Followup work will provide the builders.

Issue: google#223
@filmil
Copy link
Member Author

filmil commented Nov 11, 2021

This is going to be tricky.

  • I found out that, in order for this update to work, we'll need to update buildenv first.
    • To do that, we need to rebuild the buildenv software

@filmil
Copy link
Member Author

filmil commented Nov 11, 2021

Looks like most issues will be handled by "just" going back to the stable toolchain.
#225 handles that.

filmil added a commit that referenced this issue Nov 11, 2021
@filmil
Makes the necessary changes to have rust_icu compile with ICU 70.1
e98ec13 
The two changes needed were timezone data version regex upgrade and a test touch-up.

This has been tested locally. Followup work will provide the builders.

Issue: #223
This was referenced Jan 11, 2022
Merged
Merged
@filmil
Copy link
Member Author

filmil commented Jan 11, 2022

Inching towards 70.1 support.

filmil added a commit to filmil/rust_icu that referenced this issue Jan 11, 2022
@filmil
Uprev rust_icu to 2.0.0
04d49d7 
The uprev to 2.0.0 is due to the drop for support of ICU 67 and
the introduction of ICU 70.

Issue google#223
@filmil filmil mentioned this issue Jan 11, 2022
Merged
filmil added a commit that referenced this issue Jan 11, 2022
@filmil
Uprev rust_icu to 2.0.0
5634572 
The uprev to 2.0.0 is due to the drop for support of ICU 67 and
the introduction of ICU 70.

Issue #223
filmil added a commit to filmil/rust_icu that referenced this issue Jan 11, 2022
@filmil
Uncomments the publish target for rust_icu_sys
7c1b640 
I think at some point I forgot to revert this local change and
accidentally made it a part of a commit.

Fixes google#223
@filmil filmil mentioned this issue Jan 11, 2022
Merged
filmil added a commit that referenced this issue Mar 29, 2022
@filmil
Uncomments the publish target for rust_icu_sys
ee62cd6 
I think at some point I forgot to revert this local change and
accidentally made it a part of a commit.

Fixes #223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filmil filmil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uncomments the publish target for rust_icu_sys filmil/rust_icu
1 participant
@filmil