Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using the stable rust toolchain instead of nightly #225

Closed
filmil opened this issue Nov 11, 2021 · 1 comment
Closed

Start using the stable rust toolchain instead of nightly #225

filmil opened this issue Nov 11, 2021 · 1 comment
Assignees
@filmil

Comments

@filmil
Copy link
Member

filmil commented Nov 11, 2021

I think there are no more reasons to keep using nightly rust toolchain to build rust_icu.
@filmil filmil self-assigned this Nov 11, 2021
filmil added a commit to filmil/rust_icu that referenced this issue Nov 11, 2021
@filmil
Remove the (unused) features
027ba43 
These prevented rust_icu from being compilable with the stable rust
toolchain.  It seems that the features are unused at the moment, or
have melded into the more recent stable toolchain versions.

Issue: google#225
This was referenced Nov 11, 2021
Merged
Closed
filmil added a commit to filmil/rust_icu that referenced this issue Nov 11, 2021
@filmil
Changes to make rust_icu compile with the stable toolchain
0cb51dd 
Removes the references to the nightly toolchain.  Removes some
redundant installation as well.

Issue: google#225
filmil added a commit that referenced this issue Nov 11, 2021
@filmil
Remove the (unused) features
795f2d8 
These prevented rust_icu from being compilable with the stable rust
toolchain.  It seems that the features are unused at the moment, or
have melded into the more recent stable toolchain versions.

Issue: #225
@filmil
Copy link
Member Author

filmil commented Dec 5, 2021

Looks like we're all set on the stable toolchain. Good. :)

@filmil filmil closed this as completed Dec 5, 2021
filmil added a commit to filmil/rust_icu that referenced this issue Jan 11, 2022
@filmil
Changes to make rust_icu compile with the stable toolchain
51a73eb 
Removes the references to the nightly toolchain.  Removes some
redundant installation as well.

Issue: google#225
filmil added a commit that referenced this issue Jan 11, 2022
@filmil
Changes to make rust_icu compile with the stable toolchain
81011f2 
Removes the references to the nightly toolchain.  Removes some
redundant installation as well.

Issue: #225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filmil filmil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@filmil