Removes circular dev dependency ucal(dev)->udat->ucal #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kpozin my proposal to remove the circular dev deps. |
Build dependencies are only relevant for build.rs, which is not used in the 'ucol' crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves a few
ucaltests up the test hierarchyto remove a dev dependency of ucal onto udat. This circular
dependency makes crates.io object to the dependency structure,
even though strictly speaking a dev dependency shouldn't count.
See issue #96 for a discussion of options. I think this is the
least invasive change that we can make to keep the tests in their
current form.
Fixes: #96