Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest google3 version #297

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Update to latest google3 version #297

merged 3 commits into from
Jan 12, 2023

Conversation

jmr
Copy link
Member

@jmr jmr commented Jan 6, 2023

  • Require C++14 instead of C++11 (abseil-cpp requires it now)
  • Require googletest >= 1.10 (for gmock)
    • Location is now specified with -DGOOGLETEST_ROOT
  • New classes:
    • S2CellIterator
    • S2CellIteratorJoin
    • S2Coder
  • New StableAngle function
  • Delete many deprecated functions
  • S2Point is now a different class from Vector3_d, not a typedef for it

Fixes #259, #280, #295.

@jmr
Update to latest google3 version
ce8e338 
* Require C++14 instead of C++11 (abseil-cpp requires it now)
* Require googletest >= 1.10 (for gmock)
  * Location is now specified with -DGOOGLETEST_ROOT
* New classes:
  * S2CellIterator
  * S2CellIteratorJoin
  * S2Coder
* New StableAngle function
* Delete many deprecated functions
* S2Point is now a different class from Vector3_d, not a typedef for it
@jmr
Copy link
Member Author

jmr commented Jan 6, 2023

@smcallis @MBkkt @eengle

MBkkt
MBkkt reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@MBkkt MBkkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general thanks for updating

src/s2/s2cap.h Show resolved Hide resolved
src/s2/s2coder.h Show resolved Hide resolved
src/s2/s2coder.h Show resolved Hide resolved
src/s2/s2coder.h Show resolved Hide resolved
src/s2/s2loop.h Show resolved Hide resolved
src/s2/util/bitmap/bitmap.h Outdated Show resolved Hide resolved
MBkkt
MBkkt reviewed Jan 10, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@jmr jmr mentioned this pull request Jan 11, 2023
Merged
@jmr
Merge branch 'google3-update-2023-01-04' into update-2023-01-04
c5f46a4
@jmr
Bitmap: Remove use of nested namespace definition
f9f2ea1 
This is a C++17 feature, and we want to remain C++14-compatible.
(However, this worked for me with g++ and the default of
CMAKE_CXX_STANDARD=14.)
@jmr
Copy link
Member Author

jmr commented Jan 11, 2023

@smcallis @MBkkt tell me when you've looked at the new version.

MBkkt
MBkkt reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@MBkkt MBkkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it build and passed tests now?

Or maybe you need I try it locally?

src/s2/encoded_s2point_vector.cc Show resolved Hide resolved
@jmr
Copy link
Member Author

jmr commented Jan 11, 2023

Is it build and passed tests now?

Yes.

@jmr jmr merged commit d4a1257 into google:master Jan 12, 2023
This was referenced Jan 12, 2023
Closed
Closed
@chenrui333 chenrui333 mentioned this pull request Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcallis smcallis smcallis left review comments

@MBkkt MBkkt MBkkt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document that googletest version 1.10.0 is required
3 participants
@jmr @smcallis @MBkkt