Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix address sanitizer issue in S2Loop move ctor/assign #298

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Fix address sanitizer issue in S2Loop move ctor/assign #298

merged 1 commit into from
Jan 12, 2023

Conversation

MBkkt
Copy link
Contributor

@MBkkt MBkkt commented Jan 9, 2023

Code copied from S2Polygon

smcallis
smcallis reviewed Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@smcallis smcallis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I'll fix this internally too.

src/s2/s2loop.cc Show resolved Hide resolved
@jmr jmr mentioned this pull request Jan 9, 2023
Closed
@MBkkt
Copy link
Contributor Author

MBkkt commented Jan 10, 2023

@jmr Is it ok?

@jmr
Copy link
Member

jmr commented Jan 11, 2023

Yes, it will be merged after #297

@jmr jmr merged commit de5a372 into google:master Jan 12, 2023
@chenrui333 chenrui333 mentioned this pull request Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcallis smcallis smcallis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MBkkt @jmr @smcallis