Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paths in options parsed incorrectly on windows #884

Open
dvyukov opened this issue Nov 19, 2017 · 7 comments
Open

paths in options parsed incorrectly on windows #884

dvyukov opened this issue Nov 19, 2017 · 7 comments

Comments

@dvyukov
Copy link
Contributor

dvyukov commented Nov 19, 2017

Originally reported at golang/go#22756
It seems that we mishandle : in full windows paths in options.

@eugenis
Copy link
Contributor

eugenis commented Nov 20, 2017

Ouch :)
That's an unfortunate choice of option separator.
We could

  • not treat ":" as a separator on windows. This could be confusing.
  • not treat ":" followed by "" as a separator. This could also be confusing.
  • any other ideas?

@dvyukov
Copy link
Contributor Author

dvyukov commented Nov 20, 2017

Special case : in flags that meant to contain paths if the value starts with [a-zA-Z]:\\.

@rnk
Copy link
Contributor

rnk commented Nov 20, 2017

Everyone hits this when moving their existing sanitizer testing wrapper from Posix to Windows. It's really annoying.

Maybe the special case could only apply after =, as in =[a-zA-Z]:[/\\], since usually the paths are the entire option.

@eugenis
Copy link
Contributor

eugenis commented Nov 20, 2017

option names never start with \, it should be fine to special case any : immediately preceding that.

Stupid github lost the backslash character in my previous commit.

@rnk
Copy link
Contributor

rnk commented Nov 20, 2017

I assume option names also don't start with /. I'd like to keep that in the special case (if that's what we're doing) because it helps avoid these kinds of escaping problems.

@morehouse
Copy link
Contributor

Any progress on this?

@rnk
Copy link
Contributor

rnk commented Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants