-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of santametricservice. #605
Merged
pmarkowsky
merged 15 commits into
google:main
from
pmarkowsky:markowsky/metrics-service
Sep 22, 2021
Merged
Initial commit of santametricservice. #605
pmarkowsky
merged 15 commits into
google:main
from
pmarkowsky:markowsky/metrics-service
Sep 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The santametricservice is an XPC helper service to write metrics. It consists of Formatters and Writers. This initial commit only has support for the rawJSON format and writing to a file. This is a new daemon to be included. Docs and packaging will be updated in future PRs.
pmarkowsky
added
the
metrics
Code / work related to Santa observability / monitoring
label
Sep 22, 2021
russellhancox
requested changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run clang-format and buildifier
pmarkowsky
force-pushed
the
markowsky/metrics-service
branch
from
September 22, 2021 14:22
1221437
to
9149315
Compare
tnek
reviewed
Sep 22, 2021
russellhancox
requested changes
Sep 22, 2021
russellhancox
requested changes
Sep 22, 2021
Co-authored-by: Russell Hancox <russellhancox@users.noreply.github.com>
russellhancox
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a barebones XPC helper service to format and write metrics for monitoring systems. The structure is pretty basic with formaters and writers separated into subpackages. This initial commit only has support for the rawJSON format and writing to a file.
This is a new daemon to be included. Docs and packaging will be updated to include this in the final product will be in future PRs.
This is part of the work for #563 .