Change SNTEventLog to be a singleton emit a singleton Logger object #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlw
reviewed
Nov 10, 2021
russellhancox
requested changes
Nov 10, 2021
Co-authored-by: Russell Hancox <russellhancox@users.noreply.github.com>
russellhancox
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, SNTEventLog is already managed as effectively a singleton by the nature of all of the logging mechanisms themselves within SNTApplication anyways.
Making our logging layer a (stub-able) singleton simplifies this part of adding other EventProviders, and should make writing "did this attempt to log?" tests easier.
(prev: #668, realized the issues were unrelated but cleaned up this PR a bit more)