This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Add example configuration files #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoldie
approved these changes
Mar 6, 2017
seq2seq/test/example_config_test.py
Outdated
| EXAMPLE_CONFIG_DIR = os.path.abspath( | ||
| os.path.join(os.path.dirname(__file__), "../../example_configs")) | ||
|
|
||
| def _load_model_from_config(config_path, params, vocab_info, mode): |
There was a problem hiding this comment.
Maybe call 'params' something else here? Just weird to have a 'params' that you update with 'hparams' and then set as the input as 'params'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
Also: I changed the default behavior for invalid configuration parameters to error instead of just printing a warning. I think that's more sensible and avoids confusion. There were a few parts in the code that still used old parameters but they were "silently ignored".