The current implementation of tf.io.gfile.glob may return sorted results on __some__ filesystems. #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_510908599
branch
from
a0e16f4
to
b7187ce
Compare
copybara-service
bot
force-pushed
the
test_510908599
branch
2 times, most recently
from
0707b40
to
c950f14
Compare
copybara-service
bot
force-pushed
the
test_510908599
branch
from
c950f14
to
8861115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of tf.io.gfile.glob may return sorted results on some filesystems.
But in general this API provides no ordering guarantee on all file systems.
If, in a remote chance, that different calls to this function returns results in different orders,
the sharding logic in FileDataSource would break.
This CL sorts the results to ensure that will not happen.