Do not link native library when cross compiling for docs #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Is there no way to sign the CLA without revealing my email address? |
marc0246
force-pushed
the
cross-compilation
branch
from
ff624e5
to
b964a59
Compare
|
LGTM; but wanted to have @chyyran take a look too. |
antiagainst
changed the title
|
lgtm |
|
Can we please get a patch version bump? |
Sure; pushed a new release. |
|
Awesome, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #144 by only bailing out on the linking if cross-compilation is going on, which excludes build scripts and proc-macros. I really hate this solution, and I wish there was some other way to go about this, but at least this doesn't penalize any crates in the sense that the dependent library's author doesn't need to do anything. I just pray that this doesn't run into more unforseen complications.