Fixing duplicate absolute install paths when using Visual Studio generators

[RikoOphorst]

A slight bug occurs when running a cmake install on shaderc when using Visual Studio as a generator, where the source install file paths are incorrect. They contain a duplicate absolute path.

This issue occurred when a pull request was merged in order to fix the Ninja build system back in this PR #570

The issue is fixed by relying on the shaderc_combine_static_lib() function to properly set an absolute path on the location of the shaderc_combined custom target.

You can verify that this install behavior now works properly by running this on a Windows machine, generating for VS2017:

git clone https://github.com/RikoOphorst/shaderc
cd shaderc
mkdir build
cd build
cmake ../ -G"Visual Studio 15 2017 Win64"
cmake --build . --target install

Apologies if I'm submitting this pull request incorrectly, this is the first time I've made a pull request in any repo.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[RikoOphorst]

I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[zoddicus]

Adding @s-perron and @fjhenigman as reviewers, since they were involved in the referenced PR.

[noct]

The same change should also be applied to libshaderc_spvc\CMakeLists.txt, as that fails for the same reason.

[RikoOphorst]

@noct Should be fixed!

[dneto0]

The CI-ndk-build failure looks like a flake. Will try again.

[RikoOphorst]

@dneto0 I'm not sure what's happening with the NDK build. Could you elaborate on what steps I need to take?

[dneto0]

@dneto0 I'm not sure what's happening with the NDK build. Could you elaborate on what steps I need to take?

No action at this time. It failed mysteriously again, about when the script downloads the ninja executable. It appears wget fails with exit code 8.... ? I haven't reproduced locally. I'll try kokoro-run again.

++ dirname github/shaderc/kokoro/ndk-build/build_khronos.sh
+ SCRIPT_DIR=github/shaderc/kokoro/ndk-build
+ source github/shaderc/kokoro/ndk-build/build.sh
++ set -e
++ set -x
++ BUILD_ROOT=/tmpfs/src
++ SRC=/tmpfs/src/github/shaderc
++ wget -q https://github.com/ninja-build/ninja/releases/download/v1.7.2/ninja-linux.zip
[ID: 8884006] Build finished after 2 secs, exit value: 8

[dneto0]

oh, it looks like the second kokoro run didn't occur... I'l have to see how to kick that off again.
Hey @ehsannas can you help?

[ehsannas]

hmm.. looks like the kokoro:run label is not working today... I'll kick them off manually.

[ehsannas]

Jobs restarted

[RikoOphorst]

@ehsannas @dneto0 @noct Seems the checks have passed successfully! Anything else I need to do, or do I just wait now?

[dneto0]

Thank you @RikoOphorst for your contribution and your patience.