-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShaderTrap: Examples of computing a histogram of values #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a very good start!
I have provided detailed feedback on example 1. Please can you propagate that feedback through all the examples?
Example 2 looks incorrect and I have commented on why. I did not look beyond example 2 - so please can you revise the PR in light of my current feedback and let me know when you're ready for another review?
Also: regarding copyright headers, please see this comment that I made on Shiyu's PR:
If you can follow equivalent advice for yourself that would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
I had made a mistake in the issue description for version 3. I have tried to clarify things in the comments here, with a suggestion on how to rewrite version 3 to use vector operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Next round of changes requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm running out of time for reviewing today, so here's a very preliminary review with some nits about style. Perhaps you could look through the rest of the PR and fix up any similar style nits? I'll do a review of the actual content next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. Example 5 doesn't match the requirements of the issue, but other than that the code all looks good - my comments are mainly on your comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit - but otherwise looks good to merge assuming the bots pass!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that the contributors list is not quite right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution!
This PR Fixes #63. Providing 6 examples of histogram compute shaders.