Merge pull request #169 from google/script-readme-update

minor fixes to OKD install script and README
google · May 17, 2023 · 7754a14 · 7754a14
2 parents b265dcb + 791b235
commit 7754a14
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/okd-cluster/4.x/README.md b/okd-cluster/4.x/README.md
@@ -1,15 +1,15 @@
 
 ## Introduction
 
-Following would allow us create a OKD Cluster in the GCP Project
+Following would allow us create a OKD Cluster in the GCP Project.
+
+Scripts were tested in a linux machine.
 
 ## Requirements
-<ol>
-<li>You have owner permission and you have permission to create service account keys for your GCP project.</li>
-<li>OC cli, gcloud cli, terraform is installed.</li>
-<li>scripts were tested in a linux machine.</li>
-<li></li>
-</ol>
+
+* You have owner permission and you have permission to create service account keys for your GCP project.
+* [OC cli](https://docs.openshift.com/container-platform/4.8/cli_reference/openshift_cli/getting-started-cli.html), [gcloud cli](https://cloud.google.com/sdk/docs/install), [terraform](https://developer.hashicorp.com/terraform/tutorials/aws-get-started/install-cli) is installed.
+* You own a publicly registered DNS domain for which you can create a public Cloud DNS zone in your Google Cloud project. The setup will dynamically create a public DNS zone in your project.
 
 **Note:**
 
@@ -68,4 +68,4 @@ Following is what a key creation command may look like:
 
 ## Output
 
-After the successfull execution of the `install.sh`, the cluster details like endpoint, username and password will be shared via console logs or you can the `okd-cluster/4.x/install-config/<PROJECT_ID>/<CLUSTER_NAME>` for the logs and credentials including the KUBECONFIG for the okd cluster.
+After the successfull execution of the `install.sh`, the cluster details like endpoint, username and password will be shared via console logs or you can the `okd-cluster/4.x/install-config/<PROJECT_ID>/<CLUSTER_NAME>` for the logs and credentials including the KUBECONFIG for the okd cluster.
diff --git a/okd-cluster/4.x/install.sh b/okd-cluster/4.x/install.sh
@@ -129,6 +129,7 @@ else
    wget -O openshift-install-linux.tar.gz https://github.com/openshift/okd/releases/download/${OKD_INSTALLABALE_VERSION}/openshift-install-linux-${OKD_INSTALLABALE_VERSION}.tar.gz
    tar -xvf openshift-install-linux.tar.gz
    chmod +x openshift-install
+   mkdir -p ${CWD_PATH}/01-projectsetup/okd-installer/${OKD_VERSION}/
    mv openshift-install ${CWD_PATH}/01-projectsetup/okd-installer/${OKD_VERSION}/
 fi
 
@@ -153,7 +154,7 @@ else
    echo "############################################################"
    gcloud iam service-accounts keys create ${SA_JSON_FILENAME} --iam-account=okd-sa@${PROJECT_ID}.iam.gserviceaccount.com
    #gcloud iam service-accounts keys create test.json --iam-account=okd-sa@pm-okd-11.iam.gserviceaccount.com
-   mkdir ${CWD_PATH}/01-projectsetup/sa-keys/${PROJECT_ID}/
+   mkdir -p ${CWD_PATH}/01-projectsetup/sa-keys/${PROJECT_ID}/
    mv ${CWD_PATH}/${SA_JSON_FILENAME} ${CWD_PATH}/01-projectsetup/sa-keys/${PROJECT_ID}/
 fi