Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes to OKD install script and README #169

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

KonradSchieban
Copy link
Collaborator

Description

Addresses Openshift setup issues that were encountered in the install.sh script

Primary Components Effected

Please mark one option with an "x".

  • Shifter (Core CLI and Server Application)
  • Shifter UI (The Web Interface)
  • Cross Component Configuration (.github workflows, templates, docs, .MD files)

Type of change

Please mark one option with an "x".

  • #RELEASE New Collection of Features (containing breaking and non-breaking changes)
  • #FT New feature (non-breaking change which adds functionality, improves performance or code quality)
  • #BUG Bug Fix (non-breaking change which fixes an issue)
  • #PATCH Patch (non-breaking change which modifies only non-code object [Docs, Readme])

Developer / Author Notes

Please feel free to provide any additional notes, content or context relating to this PR and subsequent contribution.

Copy link
Collaborator

@parasmamgain parasmamgain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garybowers garybowers merged commit 7754a14 into main May 17, 2023
@garybowers garybowers deleted the script-readme-update branch May 17, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants