Restore notice max-width in setup and settings

[aaemnnosttv]

Bug Description

In #6956 we made a change to the styling of SettingsNotice to address an inconsistency with the design when used on the dashboard, but this introduced an unintended change in the other usages in setup and settings contexts where the notice streches full-width where it should be constrained as before.

Screenshots

Before

Currently

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The max-width of inline notices (as seen above) that are not used on the SK dashboard should be consistent with their pre 1.102.0 styling and a max-width of 1098px

Implementation Brief

• Restore max-width to .googlesitekit-settings-notice https://github.com/google/site-kit-wp/pull/7029/files#diff-27e3b435235c488b77baee4a111d58b139b417c5923015e3fcdd8f53a386ecd7L28 using $max-width-settings-notice-content, but scoped only to settings notices that are children of the Settings/Setup views, eg: .googlesitekit-setup-module .googlesitekit-settings-notice and .googlesitekit-setup .googlesitekit-settings-notice

Test Coverage

• No new tests needed, but VRTs may need updating.

QA Brief

• Verify that the notices shown in the Site Kit settings and setup screens are not full-width, they should have a max-width of 1098 pixels.
• Verify that notices shown in the Site Kit dashboard, e.g. Adsense Top Earning Pages widget with Analytics setup with GA4 only and ga4Reporting feature flag are full-width and do not have a max-width.

Changelog entry

• Restore notice width in setup and settings views.

[tofumatt]

This should be a quick one to implement and QA, so marking it as a 3 estimate.

[aaemnnosttv]

@tofumatt would this style be scoped to settings & setup views only? We wouldn't want to impose the same limitation on the dashboard or we'd be undoing the intentional change we made there :)

[tofumatt]

@aaemnnosttv Argh, yes, you're totally right. I even did that when testing locally but forgot to include it in the IB. I think the provided selectors make sense, they're what I used when I tried it locally.

[techanvil]

I just want to comment to say, I personally feel like this is something we'd be estimating as a 3 before the points experiment, as we had agreed a 1 would only be for super trivial things - this seems a bit more with multiple component instances to check and possible VRT updates etc.

Just chipping in because I think we need to be careful not to slip back toward our old estimations having put the experimental phase behind us...

[aaemnnosttv]

Thanks @techanvil – SGTM, I would think this one should be doable as estimated even with VRT, but I agree that it doesn't leave much room for potential complications; 7 it is!

IB ✅

[wpdarren]

QA Update: ✅

Verified:

• The notices shown in the settings and setup screens are not full-width, and have a max-width of 1098 pixels.
• Notices shown in the dashboard, e.g. Adsense Top Earning Pages widget with Analytics setup are full-width.
• Tested to make sure there are no UI/UX issues with the notices mentioned above on mobile devices.

Screenshots