Prevent error duplication in Analytics setup & settings

[mohitwp]

Bug Description

Duplicate errors appearing on Analytics setup & settings page when user a/c which have only 'View' access try to set up analytics.

Steps to reproduce

• Start set up for Analytics without having granted the edit scope
• Choose an account that the user only has Viewer-level permissions for
• Choose "Set up a new property".
• Submit the form
• When prompted, grant the additional scope to create the property
• See duplicate errors on settings page.

Screenshots

Recording.443.mp4

Additional Context

• PHP Version:
• OS: [e.g. iOS]
• Browser: [e.g. chrome, safari]
• Plugin Version: [e.g. 22]
• Device: [e.g. iPhone6]

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Since Universal Analytics has been removed from Site Kit's UI, when creating a new GA4 Property, the UA Insufficient Permissions error should not be rendered.

Implementation Brief

• In assets/js/modules/analytics/components/setup/SetupForm.js:
  • Remove rendering the StoreErrorNotices component for the analytics data store. This should be a safe fix since we do not allow creating or editing UA properties anymore.

Test Coverage

• No new tests required.

QA Brief

• Follow the steps to reproduce.
• Verify that the error notices for UA are not displayed.

Changelog entry

• Update Analytics setup and settings views to avoid showing duplicate errors.

[nfmohit]

Just a heads-up that this happens in both Analytics setup & settings screens, and the solution would be quite similar I believe. As a result, I have slightly updated the title and description to refer that.

[jimmymadon]

Can confirm that this happens on the latest develop branch too, despite removing UA from the UI - but only for the Setup Form (and not for the Settings Form anymore since we have removed the usage of assets/js/modules/analytics/components/settings/SettingsControls.js

[techanvil]

AC ✅
IB ✅

Nice one @jimmymadon :)

[mohitwp]

QA Update ✅

• Tested on dev environment.
• Verified that on dev branch error duplication error is now resolved.
• Verified that on dev branch UA error is not showing.

Recording.739.mp4