New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "Get Help" link or link within the existing text for users who encounter the google_api_connection_fail error #7994
Comments
Noting that the longer-term goal would be to implement #7986 to block users from proceeding with setup in this case. This would be a shorter-term solution prompting them to get help in order to proceed. |
Per discussion with @aaemnnosttv, this should be a small change to update this specific case, and we'll need to determine if this error ID needs to be added to the related sheet. Moving to AC. |
IB ✅ @eugene-manuilov, tagging you as a heads up re. the IB point about this needing a Service Engineering task. Update: Looks like this is already covered on Slack. |
…l-help-link Add "get help" link to Google API connection health check error
QA Update: ❌@nfmohit I have two observations that I'd like to raise.
|
Hi @wpdarren, thank you for sharing your observations.
The part that I removed ("To get more help, ask a question on our support forum and include the text of the original error message: google_api_connection_fail") is already covered in the linked documentation, so I don't think there's much point in including that again in the message. Also, this follows the pattern of other similar error messages in this context which also have a "Get help" link. @tofumatt As you had authored the ACs here, just to confirm, do you think it is still necessary to include this part in the error message? Thank you! |
As mentioned in Slack: let's keep that message in there 😄 |
Thank you folks! I've opened a follow-up PR #8028 that restores this text. Thanks! |
Restore original text in Google API connection health check error message
QA Update: ❌@nfmohit I apologize in advance for being picky, but as QA, it is what I do. 😄 Could we have the It just looks a bit odd underneath. Also, I noticed a difference in the URLs. On the AC. Have I missed something here? |
Hi @wpdarren.
I understand, however, this is the pre-existing structure of error messages like these. This issue doesn't change the structure of the message but adds to it. Here is a similar error message: For consistency, do you think it would be nicer to change all of them in a different issue?
Please let me know what you think, thanks! |
QA Update: ✅Thanks, @nfmohit, that all makes sense.
Yes, I will create a new ticket for all of these messages. Your example has bad formatting, so we should look to tidy it up, but it is a low priority in the scheme of things! Verified:
|
Bug Description
For users who encounter the
google_api_connection_fail
error, there is no immediate "Get Help" link as there are for other compatibility check errors (example).As we have new documentation making it's way through to the website, and an infrastructure change (#7864) with mini plugin that will allow users who are stuck based on IPv6 blocks, consider changing the following or similar:
Reference in codebase
An alternate to the above would be have a standard "Get help' button with the
google_api_connection_fail
error code, as we have for the AMP or REST API compatibility checks. (AMP Get Help button | REST related Get Help button)Note: There is a placeholder error code for this in our MVP error mapping sheet. This will be updated to point to the new guide making it's way through documentation.
@aaemnnosttv @adamdunnage @bethanylang
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
google_api_connection_fail
error case is encountered in the Compatibility Errors. See the component for similar links.Implementation Brief
<GetHelpLink errorCode={ error } />
to thegoogle_api_connection_fail
error case inassets/js/components/setup/CompatibilityChecks/CompatibilityErrorNotice.js
(usingcreateInterpolateElement
, similar to other cases in that file).site-kit-wp/assets/js/googlesitekit/datastore/site/urls.js
Lines 141 to 163 in 72bf365
error=google_api_connection_fail
tohttps://sitekit.withgoogle.com/documentation/troubleshooting/setup/#google_api_connection_fail
(Will require a Service Engineering task.)Test Coverage
QA Brief
/wp-json/google-site-kit/v1/core/site/data/health-checks
and selectOverride content
.https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail
Changelog entry
google_api_connection_fail
error occurs in Site Kit compatibility check.The text was updated successfully, but these errors were encountered: