New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a small overlay/callout to AdSense + GA4 users who have linked their account and now have data available to see in a widget #8237
Comments
@tofumatt @marrrmarrr Some comment as #8236, should we add a "The" in front of "top earning content" here? |
Assigning this a rough estimate of 15 just for planning purposes, but as soon as someone can take on the IB it might need slight adjustment. |
Marking this as blocked by #8236, because it contains the logic to deal with showing these notifications in general… |
IB ✔️ |
QA Update ❌
Issue I noticed clicking on Primary CTA not scrolling down to Monetization section as mentioned in AC.
Admin Main Dashboard Recording.841.mp4View only Dashboard Recording.842.mp4Q-2) I noticed that overlay is showing for all admin and on all view only dashboard. Is this expected ? PASS CASES > |
Thanks @mohitwp ! I've fixed the scrolling on a follow up PR. And yes, it's fine to appear on second admins and view only dashboard provided that the Second Admin has access to both Analytics and Adsense or both modules are shared. Sending back to CR. |
QA Update ✅
|
Feature Description
Similar in style to the callout added for users who have not linked their accounts (see #8236), we should have a callout/notification for users when there is data available for their accounts after they have been linked. Note that the style is different to many "post-connection" notifications, and instead uses a small callout/overlay.
When clicked, the "Show me" CTA button should scroll the user to the widget that displays the new info.
Figma design: https://www.figma.com/file/7ba0pj1rLuvLvJhy3NiHOj/AdSense?type=design&node-id=10-5478&mode=design&t=lwcDSKVER9BoOVmZ-0
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
ga4AdSenseIntegration
feature flag (Addga4AdSenseIntegration
feature flag #8288) is enabled. When it is disabled, there should be no overlay/prompt shown.adSenseLinked
setting (see UpdateAnalytics_4
settings to include AdSense Link-related Settings fields (adSenseLinked
andadSenseLinkedLastSyncedAt
) #8047) is set AND there is data to see in the AdSense + GA4 Top Earnings Pages report (see:site-kit-wp/assets/js/modules/adsense/components/dashboard/DashboardTopEarningPagesWidget.js
Lines 68 to 89 in 8612fe9
Implementation Brief
assets/js/components/OverlayNotification/AnalyticsAndAdSenseAccountsDetectedAsLinkedOverlayNotification.js
) using theOverlayNotificationBase
component with this overlay's content, roughly:ANALYTICS_ADSENSE_OVERLAY_DETECTED_AS_LINKED_DISMISSED = 'analytics-and-adsense-overlay-are-linked';
)const { dismissItem } = useDispatch( CORE_USER );
anddismissItem( ANALYTICS_ADSENSE_OVERLAY_DETECTED_AS_LINKED_DISMISSED )
ga4AdSenseIntegration
feature flag is enabledselect( CORE_USER ).hasAccessToShareableModule( 'analytics-4' )
)select( CORE_USER ).isItemDismissed( ANALYTICS_ADSENSE_OVERLAY_DETECTED_AS_LINKED_DISMISSED )
isfalse
useOverlayNotification
hook to manage the state of this overlay, similar to Show a small overlay/callout to AdSense + GA4 users whose accounts are not linked #8236, but with the component name'AnalyticsAndAdSenseAccountsDetectedAsLinkedOverlayNotification'
as an argument, eguseOverlayNotification( 'AnalyticsAndAdSenseAccountsDetectedAsLinkedOverlayNotification' )
.Test Coverage
AnalyticsAndAdSenseAccountsDetectedAsLinkedOverlayNotification
component.QA Brief
adSenseLinked
status #8049 for details.googlesitekit.data.select('modules/analytics-4').getAdSenseLinked()
.Changelog entry
The text was updated successfully, but these errors were encountered: