Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA events for "Top Earnings Pages" overlay CTA #8213

Closed
3 tasks
tofumatt opened this issue Feb 2, 2024 · 8 comments
Closed
3 tasks

Add GA events for "Top Earnings Pages" overlay CTA #8213

tofumatt opened this issue Feb 2, 2024 · 8 comments
Labels
javascript Pull requests that update Javascript code Module: Analytics Google Analytics module related issues P1 Medium priority Sp Wk 2 Issues to be completed in the second week of the assigned sprint

Comments

@tofumatt
Copy link
Collaborator

tofumatt commented Feb 2, 2024

Feature Description

GA events (eg. trackEvent calls) should be added to the new "Top Earnings Pages" overlay (#8237) that appears on the Site Kit dashboard when the user connects their accounts and has data available. There should be one when a user views the overlay, one when they click the "Show me" link in the overlay, and another when the user dismisses the overlay.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

CTA widget screenshot:

Screenshot 2024-02-19 at 23 35 03

Implementation Brief

Test Coverage

  • No tests needed.

QA Brief

  • Enable the ga4AdSenseIntegration feature flag
  • Use the Google Analytics debugger extension
  • Ensure your Site Kit install is set to send Analytics events/usage data to Google
  • Trigger the overlay (see QA steps for Show a small overlay/callout to AdSense + GA4 users who have linked their account and now have data available to see in a widget #8237 for details on making it appear)—connect an Analytics and AdSense accounts that are linked.
  • Visit the dashboard on a site that has data for these reports (I think oi.ie should) and view the notification
    • mainDashboard_top-earning-pages-widget, view_overlay_CTA event should be sent
  • Dismiss the notification using the "Maybe later" button in the notification
    • mainDashboard_top-earning-pages-widget, dismiss_overlay_CTA event should be sent
  • Reset all data and trigger the notification again, but this time click "Show me"
    • mainDashboard_top-earning-pages-widget, confirm_overlay_CTA event should be sent

Changelog entry

  • Add Analytics events to AdSense + Analytics notification.
@tofumatt tofumatt added P1 Medium priority Module: Analytics Google Analytics module related issues javascript Pull requests that update Javascript code labels Feb 2, 2024
@tofumatt tofumatt self-assigned this Feb 2, 2024
@bethanylang bethanylang added the Next Up Issues to prioritize for definition label Feb 2, 2024
@tofumatt
Copy link
Collaborator Author

tofumatt commented Feb 2, 2024

(Moving to stalled because this component doesn't exist yet.)

@tofumatt

This comment was marked as outdated.

@tofumatt tofumatt assigned marrrmarrr and unassigned marrrmarrr Feb 5, 2024
@tofumatt
Copy link
Collaborator Author

tofumatt commented Feb 8, 2024

@marrrmarrr @ivonac4 We now have issues filed for this component, so I've marked this as blocked by those two issues 👍🏻

@ivonac4 ivonac4 added Next Up Issues to prioritize for definition and removed Next Up Issues to prioritize for definition labels Feb 16, 2024
@tofumatt tofumatt removed their assignment Feb 17, 2024
@bethanylang bethanylang removed the Next Up Issues to prioritize for definition label Feb 21, 2024
@tofumatt tofumatt self-assigned this Feb 21, 2024
@ivonac4 ivonac4 added the Next Up Issues to prioritize for definition label Mar 6, 2024
@tofumatt tofumatt removed their assignment Mar 7, 2024
@ivonac4 ivonac4 added Sp Wk 1 Issues to be completed in the first week of the assigned sprint Sp Wk 2 Issues to be completed in the second week of the assigned sprint and removed Sp Wk 1 Issues to be completed in the first week of the assigned sprint labels Mar 11, 2024
@eugene-manuilov eugene-manuilov self-assigned this Mar 13, 2024
@eugene-manuilov
Copy link
Collaborator

@tofumatt could you please update IB to have actual implementation brief, because right now it looks like an exact copy of AC.

@tofumatt
Copy link
Collaborator Author

tofumatt commented Mar 13, 2024

@eugene-manuilov Sure thing, I had written it before the component was totally implemented 😅

EDIT: Oh, looks like the component is still in execution, I'll add more to the IB once the component is ready.

@tofumatt tofumatt assigned eugene-manuilov and unassigned tofumatt Mar 19, 2024
@tofumatt
Copy link
Collaborator Author

Updated the IB to reference the actual components, though since the issue should be completed this sprint and that issue is still in execution/code review I've referenced the PR 😄

Should be good though 😅

@eugene-manuilov
Copy link
Collaborator

Thanks, @tofumatt. IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Mar 19, 2024
@ivonac4 ivonac4 removed the Next Up Issues to prioritize for definition label Mar 20, 2024
@nfmohit nfmohit self-assigned this Mar 21, 2024
@nfmohit nfmohit removed their assignment Mar 22, 2024
@tofumatt tofumatt self-assigned this Mar 22, 2024
tofumatt added a commit that referenced this issue Mar 22, 2024
…earning-pages-overlay

Add necessary GA events for "Top Earning Pages" overlay CTA
@tofumatt tofumatt removed their assignment Mar 22, 2024
@mohitwp mohitwp self-assigned this Mar 25, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Apr 1, 2024

QA Update ✅

  • Tested on dev environment.
  • Verified that all events are getting trigger as per AC.

1> trackEvent( {viewContext}_top-earning-pages-widget, 'view_overlay_CTA' ) when the notification is rendered and shown to the user

image

2> trackEvent( {viewContext}_top-earning-pages-widget, 'confirm_overlay_CTA' ) when the user clicks the "Show me"/primary CTA

image

Recording.843.mp4

3> trackEvent( {viewContext}_top-earning-pages-widget, 'dismiss_overlay_CTA' ) when the user clicks the "Maybe later"/secondary CTA

image

Recording.844.mp4

@mohitwp mohitwp removed their assignment Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Module: Analytics Google Analytics module related issues P1 Medium priority Sp Wk 2 Issues to be completed in the second week of the assigned sprint
Projects
None yet
Development

No branches or pull requests

8 participants