Remove Ads bullet point from Consent Mode modal when Ads is not connected.

[techanvil]

Feature Description

When an Ads Conversion ID has not been set up, we should not show the "Performance of your Ad campaigns" bullet point in the disable modal (screenshots taken from Figma):

As a result the copy above the bullet points should also be updated, so the modal description and bullet point list should read as follows:

See also the related issue #8389.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• When Ads is not considered "connected" for the purpose of the Consent Mode feature:
  • The Consent Mode disable modal should have its description copy updated as per the latest iteration of the Figma design:
    • Disabling consent mode may affect your ability in the European Economic Area and the United Kingdom to:
  • The bullet point relating to Ads should be removed.
  • The remaining bullet point's copy should be updated to: Track how visitors interact with your site
• Note that for Ads to be considered connected within this context, at least of one of the following should be true:
  • An Ads Conversion Tracking ID has been configured.
  • An Ads link has been created for the current GA4 property.
  • The Google tag for the current GA4 property has an Ads tag as a destination.

Implementation Brief

• Update assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.js:
• Get the adsConversionID from the MODULE_ADS store using the getAdsConversionID selector.
• Add a new variable that uses useMemo to return a new provides array based on the Ads Conversion ID's presence:

	const provides = useMemo( () => {
		let providesArray = [
			__(
				'How visitors interact with your site via Analytics',
				'google-site-kit'
			),
		];

		if ( adsConversionID !== undefined && adsConversionID !== '' ) {
			providesArray = [
				...providesArray,
				__( 'Performance of your Ad campaigns', 'google-site-kit' ),
			];
		}

		return providesArray;
	}, [ adsConversionID ] );

• Update the provides prop on the ModalDialog to take the new provides array: provides={ provides }

Test Coverage

• No additional test coverage is required.

QA Brief

Ads Module Connected

• Ensure the Ads module is connected.
• Navigate to Settings->Admin Settings page.
• Disable the "Enable consent mode" toggle switch.
• Verify that the modal's description remains unchanged from the current version.
• Confirm that the list of bullet points remains unchanged from the current version.

Ads Module Disconnected

• Disconnect the Ads module.
• Navigate back to the Settings -> Admin Settings page.
• Again, disable the "Enable Consent Mode" toggle switch.
• Verify that the modal's description is updated to match the specific text provided in the AC.
• Ensure that the bullet point related to the Ads module is removed. Confirm that the remaining bullet point is updated as specified in the AC.

Changelog entry

• Remove warning about Ad campaigns in the Consent Mode deactivation modal if Google Ads is not connected.

[eugene-manuilov]

IB ✔️

[hussain-t]

Hi @techanvil, we have updated the description copy to include "and the United Kingdom" as part of #8389. Could you confirm if, in the absence of the Ads conversion ID, the description should now read: "Disabling consent mode may affect your ability in the European Economic Area and the United Kingdom to"? Also, should the bullet point be revised to "Track how visitors interact with your site"?

[techanvil]

Hi @hussain-t, thanks for raising this. The copy should indeed be updated as you've pointed out.

I've also realised the AC had become a bit out of date with regard to the conditions for determining if Ads is connected, and have updated it accordingly. Please can you ensure the implementation follows the AC? If you want to send it back to IB to ensure the IB is also aligned, please feel free to do so, but if you prefer to simply address this during execution that seems fine to me too.

[hussain-t]

Thanks for the clarification, @techanvil. We don't need to move it to IB. I will address the changes in my PR.

[wpdarren]

QA Update: ✅

Verified:

Ads Module Connected

• The modal's description remains unchanged from the current version.
• The list of bullet points remains unchanged from the current version.

Ads Module Disconnected

• The modal's description is updated to match the specific text provided in the AC.
• The bullet point related to the Ads module is removed.
• The remaining bullet point is updated as specified in the AC.

I tested this when:

• An Ads Conversion Tracking ID was configured.
• An Ads link was created for the current GA4 property. (oi.ie)
• The Google tag for the current GA4 property has an Ads tag as a destination.